{Misc} Remove direct call to msrestazure
#29856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evelyn-ys
requested review from
calvinhzy,
jiasli,
jsntcy,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
evelyn-ys
requested review from
AllyW,
bebound,
digimaun,
kairu-ms,
necusjz and
yonzhan
as code owners
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Misc |
FumingZhang
approved these changes
Sep 12, 2024
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Approve for the change related to acs (AKS, src/azure-cli/azure/cli/command_modules/acs). Thanks!
Collaborator
|
Please fix conflicting files |
wanyang7
reviewed
Sep 13, 2024
src/azure-cli/azure/cli/command_modules/synapse/manual/operations/sqlpoolsensitivitylabel.py
Outdated
Show resolved
Hide resolved
Member
|
This is a very big RP. I would suggest creating separate PRs for each change:
|
evelyn-ys
modified the milestones:
September 2024 (2024-10-08),
October 2024 (2024-11-05)
calvinhzy
approved these changes
Sep 24, 2024
necusjz
approved these changes
Sep 24, 2024
kairu-ms
approved these changes
Sep 24, 2024
zhoxing-ms
approved these changes
Sep 24, 2024
wanyang7
approved these changes
Sep 24, 2024
Member
|
Approve for the change related to |
Member
|
I actually did the |
jiasli
approved these changes
Sep 25, 2024
Member
|
I am actually considering moving |
3 tasks
yonzhan
approved these changes
Sep 29, 2024
jsntcy
approved these changes
Sep 29, 2024
Member
Author
|
azure-cli/src/azure-cli-core/azure/cli/core/util.py Lines 258 to 262 in 05a5d8f Will fix in separate PR |
This was referenced Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
We are planning to drop
msrestazuredependency as described in it's disclaimerSo this PR mainly works on migrating
msrestazure.toolstoazure.mgmt.core.toolsmsrestazure.azure_exceptions.CloudErrortoazure.core.exceptions.HttpResponseErrorThere're some other
msrestazurecalls left includingdlamodule (will deprecate in next breaking change window [dla]az dla: Deprecate azure datalake analytics from CLI #29879 )dlsmodule (cc @akharit for awareness)keyvaultmodule (will discuss with keyvault service team)msrestazure.azure_cloud._populate_from_metadata_endpointcall incloudmodule ({Cloud} Remove msrestazure call in cloud module #30068 )msrestazure.azure_operation.AzureOperationPollerinresourcemodule ({Resource} Remove direct call tomsrestazure#29959 )We will handle these cases in separate PRs
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.